Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bidi][js] Add script message event #13153

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

pujagani
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Adding https://w3c.github.io/webdriver-bidi/#event-script-message APIs to the JS Bindings

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani pujagani added C-nodejs C-devtools BiDi or Chrome DevTools related issues labels Nov 15, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8cebe10) 57.52% compared to head (f52aabb) 57.52%.
Report is 1 commits behind head on trunk.

❗ Current head f52aabb differs from pull request most recent head 1dcafa2. Consider uploading reports for the commit 1dcafa2 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13153   +/-   ##
=======================================
  Coverage   57.52%   57.52%           
=======================================
  Files          86       86           
  Lines        5299     5299           
  Branches      221      221           
=======================================
  Hits         3048     3048           
  Misses       2030     2030           
  Partials      221      221           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pujagani pujagani merged commit 173d624 into SeleniumHQ:trunk Dec 18, 2023
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-devtools BiDi or Chrome DevTools related issues C-nodejs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants