Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js] download files from remote server #13102

Merged
merged 7 commits into from
Jan 3, 2024
Merged

[js] download files from remote server #13102

merged 7 commits into from
Jan 3, 2024

Conversation

titusfortner
Copy link
Member

Status

In draft because downloadFile does not yet work.

@harsha509 I updated this as best I can figure, but downloadFile is a copy/paste from ChatGPT and I'd be shocked if it worked. Can you help me figure out the right implementation for that functionality?

Description

  • adds capability enableDownloads
  • errors if using method without setting capability
  • getDownloadableFiles returns direct list of names
  • downloadFIle — needs help
  • downloadFile creates directory if does not exist
  • deleteDownloadableFiles deletes all files

Motivation and Context

implement #11657

@titusfortner titusfortner changed the title Js download [js] download files from remote server Nov 6, 2023
* [JS] check if downlaods are enabled

* [js] resolve promise before checking for names

* [JS] unzip files with correct headers
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @titusfortner

@titusfortner titusfortner marked this pull request as ready for review January 3, 2024 03:14
@titusfortner titusfortner merged commit 8b5ba75 into trunk Jan 3, 2024
14 of 16 checks passed
@titusfortner titusfortner deleted the js_download branch January 3, 2024 03:17
@limuyuan
Copy link

limuyuan commented Jun 5, 2024

Hello @titusfortner , is using JS to download files from Remote WebDriver still not supported?

@titusfortner
Copy link
Member Author

It should work. Are you having a problem?

@limuyuan
Copy link

limuyuan commented Jun 7, 2024

It should work. Are you having a problem?

I'm always getting the below error message when trying to downloadFile

 Uncaught WebDriverError WebDriverError: Cannot find file [[selenium-java-4.21.0.zip]] in directory C:\Users\admin\AppData\Local\Temp\1\uuid13931905917359662002f7930a56-f43c-4f3d-b955-d6cfd9cafa88\download16040450071988999621.

I found this PR from changelog and I have noticed you said the downloadFile should not work.
After comparing codes with the trunk, there's nothing new, so I believe it's still not working.

@limuyuan
Copy link

limuyuan commented Jun 8, 2024

I have submitted an issue: #14111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants