Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Close dev tools session safely #12660

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Sep 1, 2023

Description

To avoid potential deadlock we need execute async methods via wrapping it as Task.

Motivation and Context

Related to #10008 and #12592

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I have tested the fix, deadlock disappeared.

@jimevans jimevans merged commit d670a70 into SeleniumHQ:trunk Sep 1, 2023
@nvborisenko nvborisenko deleted the devtools-close branch September 1, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants