-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust] Automated Firefox management (#11680 and #11682) #12582
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CandorContent
pushed a commit
to CandorContent/selenium
that referenced
this pull request
Aug 25, 2023
…11682) (SeleniumHQ#12582) * [rust] Automated Firefox management (Linux) (SeleniumHQ#11680) * [rust] Automated Firefox management (macOS) (SeleniumHQ#11680) * [rust] Automated Firefox management (Windows) (SeleniumHQ#11680) * [rust] Refactoring and improving logs * [rust] Include test for downloading latest Firefox version * [rust] SM downloads fixed version of Firefox browser (SeleniumHQ#11682) * [rust] Update cargo lock file * [rust] Complete automated Firefox management when a version is specified * [rust] Include argument --avoid-browser-download * [rust] Error in unsupported browser download functions in different modules * [rust] Include logic to uncompress dmg files (required in Firefox nightly in macOS) * [rust] Improve command to move pkg payload * [rust] Support downloading Firefox versions lower than 68 * [rust] Improve condition to display warning due to driver in path * [rust] Rename resolve driver function to setup * [rust] Replace crate bzip2-rs with bzip2
titusfortner
added a commit
that referenced
this pull request
Aug 27, 2023
titusfortner
added a commit
that referenced
this pull request
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements Firefox's automated browser management feature for the latest (stable) and given versions (unstable -beta, dev, nightly- and fixed versions -e.g., 116, 117, etc.-).
The minimum manageable Firefox versions by SM are the following (although it is improbable that ancient versions could be automated with Selenium):
Some examples:
As a plus, this PR includes a new argument called
--avoid-browser-download
, which prevents browser download even when the browser version is specified. This argument is irrelevant to the bindings. I implemented it to ease some tests and just in case someone using SM as a CLI tool needs it (like--force-browser-download
).Motivation and Context
This PR implements #11680 and #11682, and it has been tested on:
Types of changes
Checklist