Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] add support for selenium manager #11189

Merged
merged 11 commits into from
Nov 2, 2022
Merged

[JS] add support for selenium manager #11189

merged 11 commits into from
Nov 2, 2022

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Oct 28, 2022

Description

  • Implements selenium-manager in js bindings
  • if browser driver is not in path selenium-manager does the work for chrome and firefox

depends on :
#11120 -> common/manager/bazel.build for visibility of files during build

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@titusfortner titusfortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially we don't want users to know that there's a Selenium Manager trying to do things for them, because if it works they don't care, and if it doesn't work they can't do anything about it.

javascript/node/selenium-webdriver/chrome.js Outdated Show resolved Hide resolved
javascript/node/selenium-webdriver/chrome.js Outdated Show resolved Hide resolved
javascript/node/selenium-webdriver/firefox.js Outdated Show resolved Hide resolved
javascript/node/selenium-webdriver/firefox.js Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@titusfortner titusfortner merged commit e14c264 into SeleniumHQ:trunk Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants