Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Fix msedgedriver uncompression in Selenium Manager #11180

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

bonigarcia
Copy link
Member

Description

This PR fix a bug in Selenium Manager, related to the uncompression of msedgedriver.

Motivation and Context

@titusfortner recently discovered that there was a problem when downloading msedgedriver with Selenium Manager (it uses the licence terms instead of the actual binary). This PR solves that bug.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner titusfortner merged commit 615bbb9 into trunk Oct 27, 2022
@titusfortner titusfortner deleted the se_mgr_fix_edge branch October 27, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants