[grid] Add ability to use Enter key to confirm #11178

mhnaeem · 2022-10-26T23:37:11Z

Description

This change adds a onKeyDown handler for the input field, the handler listens for Enter key press and calls the onConfirm callback, this change allows the user confirm the dialog using the Enter key instead of pressing the Confirm button

Motivation and Context

Fixes #11177

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

I have read the contributing document.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

This change adds a onKeyDown handler for the input field, the handler listens for Enter key press and calls the onConfirm callback, this change allows the user confirm the dialog using the Enter key instead of pressing the Confirm button Fixes SeleniumHQ#11177

codecov-commenter · 2022-10-31T05:25:35Z

Codecov Report

Base: 52.67% // Head: 52.67% // No change to project coverage 👍

Coverage data is based on head (a0dc378) compared to base (f569d7f).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #11178   +/-   ##
=======================================
  Coverage   52.67%   52.67%           
=======================================
  Files          82       82           
  Lines        5542     5542           
  Branches      198      198           
=======================================
  Hits         2919     2919           
  Misses       2425     2425           
  Partials      198      198

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.