Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Include --driver flag to Selenium Manager #11123

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

bonigarcia
Copy link
Member

Description

This PR includes a new argument to Selenium Manager called --driver, which is equivalent to --browser (i.e., it allows to select the driver to be managed), but using the driver name (i.e., chromedriver, geckodriver, or msedgedriver) instead of the browser name (chrome, firefox, edge).

Motivation and Context

This is part of the development of Selenium Manager M1, to ease the integration with the Selenium bindings (e.g., in the DriverService class of the Java bindings, we have the driver name instead the browser name).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@titusfortner titusfortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! this would simplify the code I'm writing quite a bit
Depending on where the project goes we might want to do more with the errors, but at the point we're using it within the bindings, I think this is good.

@titusfortner titusfortner merged commit 5bf00b4 into trunk Oct 14, 2022
@titusfortner titusfortner deleted the manager-driver-flag branch October 14, 2022 00:59
@diemol diemol added the hacktoberfest-accepted Temporary label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants