[py]: #11093 - The SessionId shouldn't be added to params themself bu…

[tvataire]

…t to a copy of them.

Description

The Webdriver.execute() method shouldn't add the SessionId to its params themself but to a copy of them.
This avoid the SessionId to be preserved in the PrintOptions instance.

Motivation and Context

If the session id is stored inside the PrintOptions instance, a selenium.common.exceptions.InvalidSessionIdException is raised when the PrintOptions instance is reused in a subsequent session.

Types of changes

• [x ] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• [x ] I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[titusfortner]

ah, nice solution. Can you add a unit test?

[tvataire]

Hi
An unit test is ready but I couldn't find the way to run the tests.
When I run a bazel command, nothing happens.
I tried these commands :
bazel build //py:selenium
bazel test //py:test-firefox
A bazel process is started, but it never ends and nothing is displayed on stdout.
Can somebody help me to fix this.

[tvataire]

Ok, my install of bazel was broken.
Seems to work properly now...

[codecov-commenter]

Codecov Report

Base: 52.67% // Head: 52.67% // No change to project coverage 👍

Coverage data is based on head (7312569) compared to base (aa23847).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #11121   +/-   ##
=======================================
  Coverage   52.67%   52.67%           
=======================================
  Files          82       82           
  Lines        5542     5542           
  Branches      198      198           
=======================================
  Hits         2919     2919           
  Misses       2425     2425           
  Partials      198      198           

Impacted Files	Coverage Δ
py/selenium/webdriver/remote/webdriver.py	41.65% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[titusfortner]

thanks!