Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Include optimization parameters for Selenium Manager releases #11116

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

bonigarcia
Copy link
Member

Description

This PR includes some Cargo configuration parameters to optimize each Selenium Manager release (in size).

Motivation and Context

The current combined weight of Selenium Manager (Windows+Linux+macOS) is 23.7 MB. It would be desirable to reduce this number, to distribute these binaries within each binding release.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@titusfortner titusfortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My take is that this is a beta and we can take the shortcuts until someone reports a problem with them. :)

@titusfortner titusfortner merged commit 5c375dd into trunk Oct 13, 2022
@titusfortner titusfortner deleted the manager-optimization branch October 13, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants