-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust] Add --browser-version and --driver-version to selenium-manager #11100
Conversation
ccdec32
to
608030d
Compare
Is Is the idea to be able to do:
|
It is already implemented in this PR. But the idea is use one or another ( For example if you want to download an specific driver, you use
If you want to force a (major) browser version, you use
|
Ah, right, I didn't actually read the changes, sorry. What errors is this giving when users send conflicting values? |
I have just committed a new patch with a test checking error conditions, and also, some logic to warn the user when both |
Codecov ReportBase: 52.31% // Head: 52.31% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## trunk #11100 +/- ##
=======================================
Coverage 52.31% 52.31%
=======================================
Files 82 82
Lines 5503 5503
Branches 198 198
=======================================
Hits 2879 2879
Misses 2426 2426
Partials 198 198 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Description
This PR includes two new configuration options for Selenium Manager (implemented as CLI arguments):
--browser-version
: To force a given major browser version (e.g.,105
,106
, etc.).--driver-version
: To force a given driver version (e.g.,106.0.5249.61
,0.31.0
, etc.).Motivation and Context
This PR is part of the development of Selenium Manager M1.
Types of changes
Checklist