isPromise() thenable fix #11048
Merged
isPromise() thenable fix #11048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
harsha509
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
Tested the changes locally. Was able to reproduce the issue!
Thank you for the fix @cstringer !
|
I'm very happy to contribute, thank you @harsha509 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #11045
This reverts changes to the
isPromise()utility function (84dd610) which causes the function to returnfalsefor "thenable" objects (i.e. objects or functions exposing athen()method, such asWebElementPromise)Additionally assertions have been added to the
promise_test.jstest case forisPromise()to verify the above behavior.Motivation and Context
Without the above change, "thenable" objects/functions will not pass the
isPromise()test, and subsequest methods which rely on it (such asWebDriver.wait()fail.Types of changes
Checklist