[java] Deprecate max-threads flag. Add an alternate flag in the distributor for new session thread pool size. #10995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pujagani
changed the title
pujagani
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #10995 +/- ##
========================================
Coverage ? 52.28%
========================================
Files ? 81
Lines ? 5499
Branches ? 198
========================================
Hits ? 2875
Misses ? 2426
Partials ? 198 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
SonarCloud Quality Gate failed. |
|
SonarCloud Quality Gate failed. |
diemol
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Related to #10332.
Motivation and Context
The "max-threads" flag was intended to be used in the Distributor and this was mainly used in Grid 3. However, in Grid 4, the flag's value is not actually being used. So "max-threads" is deprecated and will be removed minimum 2 versions later. As an alternative, a new flag is added to the distributor whose value is used in the code base.
The new session creation thread pool size affects the Distributor's ability to create sessions parallel. In most cases, the default thread pool size should be sufficient. But in a large grid, it might be beneficial for the user to set its value as required. Thus, making the thread pool size configurable.
Types of changes
Checklist