[java] Migrate base for Closure tests to JUnit Jupiter (JUnit 5) #10786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the migration of Java tests to JUnit 5 (issue SeleniumHQ#10196).
|
Kudos, SonarCloud Quality Gate passed!
|
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
…eniumHQ#10786) * [java] Migrate based for Closure tests to Jupiter (JUnit 5) Part of the migration of Java tests to JUnit 5 (issue SeleniumHQ#10196). * Include SHA for bazel-contrib/rules_jvm * [java] smell-fix: DriverSupplier is always an instance of Closeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The JavaScript build contains a set of Closure tests (HTML + JavaScript) that are executed through Selenium and Java. These tests were based originally on JUnit 4. This PR migrates the test base required for that tests to JUnit 5, using dynamic tests (that use the set of HTML file to generate dynamically the Closure tests).
Motivation and Context
Migration of Java tests to JUnit 5 (issue #10196).
Types of changes
Checklist