[JS] Fix: using fulfillRequest when intercepting #10764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
Co-authored-by: Sri Harsha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The implementation of Network Interception BiDi command is outdated and no longer works (for JavaScript atleast).
It uses
Fetch.continueRequestCDP command, which is now used to change the parameters of request only and not the response. The correct command to be used now isFetch.fulfillRequestwhich mocks the response.Motivation and Context
Types of changes
Checklist