Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Run tests on the JUnit Platform (JUnit 5) #10752

Merged
merged 10 commits into from
Jun 9, 2022

Conversation

bonigarcia
Copy link
Member

Description

This PR enables java_test_suite from contrib_rule_jvm to use the JUnit Platform for running test cases. It uses the JUnit 4 runner by default since most existing tests are JUnit 4-based. New test cases can be based on JUnit Jupiter. We can migrate the existing JUnit 4 tests to JUnit Jupiter as a future step.

Motivation and Context

Migration of Java tests from JUnit 4 to JUnit 5 (issue #10196).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bonigarcia!

@diemol diemol merged commit f9018c6 into SeleniumHQ:trunk Jun 9, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bonigarcia bonigarcia deleted the junit-platform branch June 9, 2022 13:27
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
* [java] Use java_test_suite and from contrib_rule_jvm

First step in the migration of the test codebase to JUnit 5

issue SeleniumHQ#10196

* [java] Manage JUnit 5 dependencies, using junit-vintage for existing tests

Second step in the migration of the test codebase to JUnit 5

issue SeleniumHQ#10196

* [java] Move interface HasMagicNumbers to a separate class

issue SeleniumHQ#10196

* [java] Include missing dependencies

issue SeleniumHQ#10196

* [java] Include additional JUnit 5 dependencies

issue #10196q

* [java] Use JUnit 4 runner by default

Since the existing tests are based on JUnit 4

issue SeleniumHQ#10196

* [java] Remove lint tests for contrib_rules_jvm macros

Pull java_test and java_library from contrib_rules_jvm
and not from the default packages

issue SeleniumHQ#10196

* [java] Bump to contrib_rules_jvm version 0.3.0

* [java] Use spotbugs as linter from contrib_rules_jvm

Co-authored-by: Diego Molina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants