[py]: Find latest version of devtools when requested version does not exist on disk
#10749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…request version does not exist on disk
Codecov Report
@@ Coverage Diff @@
## trunk #10749 +/- ##
==========================================
+ Coverage 47.27% 47.30% +0.03%
==========================================
Files 86 86
Lines 5580 5589 +9
Branches 278 278
==========================================
+ Hits 2638 2644 +6
- Misses 2664 2667 +3
Partials 278 278
Continue to review full report at Codecov.
|
symonk
commented
Jun 8, 2022
symonk
commented
Jun 8, 2022
py/test/unit/selenium/webdriver/common/cdp_module_fallback_tests.py
Outdated
Show resolved
Hide resolved
AutomatedTester
approved these changes
Jun 13, 2022
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
… not exist on disk (SeleniumHQ#10749) * [py]: Allow `devtools` imports to look for the latest version if the request version does not exist on disk * [py]: use `selenium` logger for `devtools` fallback Co-authored-by: David Burns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a little resilliency to the python bindings when the requested
devtools/v{n}cannot be found on disk. This can happen when CDP is updated and python has not yet been released. It will parse out all the version available in the/devtools/*path and select the latest one only if the requestedveris not available and raises aModuleNotFoundError.This makes a few assumptions that the only contents in
/devtoolswill be folders prefixed withv{some_number}.closes #10699