Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] Removed desired capabilities from handshake code #10494

Merged

Conversation

SinghHrmn
Copy link
Contributor

Description

Fixes #10264

Motivation and Context

Python still sends both capabilities and desired capabilities to the driver, which can result in an OSS session that isn't properly supported any more.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #10494 (da113fa) into trunk (ed74210) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##            trunk   #10494   +/-   ##
=======================================
  Coverage   45.04%   45.05%           
=======================================
  Files          85       85           
  Lines        5523     5522    -1     
  Branches      269      268    -1     
=======================================
  Hits         2488     2488           
  Misses       2766     2766           
+ Partials      269      268    -1     
Impacted Files Coverage Δ
py/selenium/webdriver/remote/webdriver.py 39.75% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed74210...da113fa. Read the comment docs.

@AutomatedTester
Copy link
Member

It looks like you didn't run the tests.

@SinghHrmn SinghHrmn force-pushed the feat-deprecate-oss-capabilities branch from da113fa to e33afb2 Compare April 6, 2022 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: Remove Handshake code in Python
3 participants