Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: SeleniumServer.start() crashes on MacOS with nodejs selenium-webdriver #12076

Closed
bswhb opened this issue May 22, 2023 · 5 comments · Fixed by #12158
Closed

[🐛 Bug]: SeleniumServer.start() crashes on MacOS with nodejs selenium-webdriver #12076

bswhb opened this issue May 22, 2023 · 5 comments · Fixed by #12158

Comments

@bswhb
Copy link
Contributor

bswhb commented May 22, 2023

What happened?

The jar file selenium-server-4.9.jar is placed in MacOS userdata which is /Users/<username>/Library/Application Support/<appname>/selenium-server/4.9.0/selenium-server.jar, as we can see, there's a space in the path.

The space will break the ChildProcess.execSync function which is used to detect the version of the jar file.

We suggest to change the following execSync function with execFileSync in selenium-webdriver/remote/util.js:

  // const execRes = cp.execSync(
  //   `${javaPath} -jar ${seleniumStandalonePath} --version`
  // )
  const execRes = cp.execFileSync(javaPath, ['-jar', seleniumStandalonePath, '--version'])

How can we reproduce the issue?

  const seleniumPort = await detect(4852)
  logger.info(`Starting up webdriver server on port ${seleniumPort}...`)
  seleniumServer = new SeleniumServer(
    join(userdataPath, 'selenium-server', package.dependencies['selenium-server'], 'selenium-server.jar'), {
      jvmArgs: [
        '-Dwebdriver.server.session.timeout=86400'
      ],
      port: seleniumPort
    })
  await seleniumServer.start()

Relevant log output

Error: Command failed: /Users/<username>/Library/Application Support/<appname>/openjdk/1.8.0/bin/java -jar /Users/<username>/Library/Application Support/<appname>/selenium-server/4.9.0/selenium-server.jar --version
/bin/sh: /Users/<username>/Library/Application: No such file or directory


### Operating System

MacOS Big Sur 11.7.6

### Selenium version

4.9.0

### What are the browser(s) and version(s) where you see this issue?

N/A

### What are the browser driver(s) and version(s) where you see this issue?

N/A

### Are you using Selenium Grid?

_No response_
@github-actions
Copy link

@bswhb, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@diemol
Copy link
Member

diemol commented May 22, 2023

Would you like to send a pull request?

@un-limite
Copy link

That's good!

bswhb added a commit to bswhb/selenium that referenced this issue Jun 6, 2023
@bswhb
Copy link
Contributor Author

bswhb commented Jun 6, 2023

PR created, thanks for reminding: #12158

diemol added a commit that referenced this issue Jun 9, 2023
…-webdriver (#12158)

* [js] use generated selenium manager artifacts for testing

* #12076 fix

---------

Co-authored-by: titusfortner <[email protected]>
Co-authored-by: Diego Molina <[email protected]>
Copy link

github-actions bot commented Dec 9, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants