You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for contributing to the Docker-Selenium project! A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Env var SE_NODE_PLATFORM_NAME can be used to unset default value Linux in Node stereotype. This supports to work with autoscaling with KEDA, aligned config with scaler trigger params platformName
Motivation and Context
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
The browser version comparison appears twice in the code with different conditions - one using case-insensitive comparison (${SE_NODE_BROWSER_VERSION,,}) and another using direct comparison. This could lead to inconsistent behavior.
if [ -f /opt/selenium/browser_version ] && [ "${SE_NODE_BROWSER_VERSION,,}" = "stable" ]; then
SE_NODE_BROWSER_VERSION=$(short_version $(cat /opt/selenium/browser_version))
fi
The else clause for SE_NODE_STEREOTYPE simply assigns the existing value to itself without providing a meaningful default, which could result in an empty or invalid stereotype configuration.
Add validation for environment variable to prevent potential JSON parsing errors
Add input validation to ensure SE_NODE_PLATFORM_NAME is not empty before using it in the stereotype JSON, as an empty value could cause JSON parsing errors.
Why: Adding validation for SE_NODE_PLATFORM_NAME is crucial as an empty value could cause JSON parsing errors and system failures. The suggestion provides a good fallback to "Linux" which maintains backward compatibility.
8
Remove duplicate code block and ensure consistent case-insensitive version comparison
Fix the duplicate code block that appears in two different hunks, as it could lead to unexpected behavior when checking browser version.
Why: The suggestion correctly identifies a duplicate code block and proposes using the case-insensitive comparison consistently. This helps prevent potential bugs from case sensitivity issues and improves code maintainability.
The action failed due to SSL certificate verification issues. The tests were unable to connect to the Selenium Grid because it was using a self-signed certificate that could not be verified. Specifically:
1. The smoke test failed with: "Container status was not fetched on port 31444/selenium" 2. Multiple test cases failed with SSL errors: "[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate" 3. The tests were unable to establish secure connections to the Selenium Grid at 10.1.0.152:31444 due to the certificate verification failures
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Env var
SE_NODE_PLATFORM_NAME
can be used to unset default valueLinux
in Node stereotype. This supports to work with autoscaling with KEDA, aligned config with scaler trigger paramsplatformName
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
SE_NODE_PLATFORM_NAME
to allow configurable platform name in node stereotypeChanges walkthrough 📝
Dockerfile
Add platform name environment variable configuration
NodeBase/Dockerfile
SE_NODE_PLATFORM_NAME
with defaultvalue "Linux"
generate_config
Make platform name configurable in node stereotype
NodeBase/generate_config
${SE_NODE_BROWSER_VERSION,,}
SE_NODE_PLATFORM_NAME
instead of hardcoded "Linux"