chart(update): Node deployment replicas use minReplicaCount in autoscaling #2430
+52
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
When enabling autoscaling, type: Deployment. In chart template, field
replicas
is not defined in deployment spec, K8s will assume it as 1 by default.When
autoscaling.scaledOptions.minReplicaCount
set as 0, we can see 1 Node pod is up then it's Terminating to reach replicas 0/0Or when
autoscaling.scaledOptions.minReplicaCount
set > 1, also there is 1 Node pod up from the beginning before it is scaled up to reach the minReplicaCount.So, when enabling autoscaling && type = Deployment, minReplicaCount is used to set replicas in deployment spec
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
RollingUpdate
in chart configurations.minReplicaCount
when autoscaling is enabled for Chrome, Edge, and Firefox nodes.Changes walkthrough 📝
4 files
chart_test.sh
Enhance debugging information in test script
tests/charts/make/chart_test.sh
chrome-node-deployment.yaml
Use minReplicaCount for Chrome node replicas
charts/selenium-grid/templates/chrome-node-deployment.yaml
minReplicaCount
when autoscaling is enabled.edge-node-deployment.yaml
Use minReplicaCount for Edge node replicas
charts/selenium-grid/templates/edge-node-deployment.yaml
minReplicaCount
when autoscaling is enabled.firefox-node-deployment.yaml
Use minReplicaCount for Firefox node replicas
charts/selenium-grid/templates/firefox-node-deployment.yaml
minReplicaCount
when autoscaling is enabled.1 files
__init__.py
Clean up unused variable in Selenium test
tests/SeleniumTests/init.py
is_continue
.1 files
test.py
Update strategy assertion change in test
tests/charts/templates/test.py
Recreate
toRollingUpdate
.3 files
config.yml
Add configuration for Firefox language and downloads in CI
.circleci/config.yml
downloads.
Makefile
Update Makefile for Firefox and download configurations
Makefile
Firefox and downloads.
values.yaml
Default update strategy set to RollingUpdate
charts/selenium-grid/values.yaml
RollingUpdate
.1 files
CONFIGURATION.md
Update chart version and default strategy
charts/selenium-grid/CONFIGURATION.md
RollingUpdate
.1 files
Chart.yaml
Bump chart and dependency versions
charts/selenium-grid/Chart.yaml