-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chart(update): use podIP in all components server host #2429
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
CI Failure Feedback 🧐(Checks updated until commit cc2dd65)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Fixes #2065
--host
refer tostatus.podIP
Types of changes
Checklist
PR Type
enhancement, configuration changes
Description
Changes walkthrough 📝
3 files
chart_cluster_setup.sh
Add service mesh configuration for Minikube setup
tests/charts/make/chart_cluster_setup.sh
SERVICE_MESH
variable with default valuefalse
.SERVICE_MESH
is true.helm-chart-test.yml
Integrate service mesh configuration in CI workflow
.github/workflows/helm-chart-test.yml
service-mesh
configuration to test matrix.SERVICE_MESH
to chart cluster setup command.values.yaml
Disable node service creation by default
charts/selenium-grid/values.yaml
false
.7 files
_helpers.tpl
Use pod IP for node host configuration
charts/selenium-grid/templates/_helpers.tpl
SE_NODE_HOST
environment variable to use pod IP.distributor-deployment.yaml
Use pod IP for distributor host configuration
charts/selenium-grid/templates/distributor-deployment.yaml
SE_DISTRIBUTOR_HOST
to use pod IP.event-bus-deployment.yaml
Use pod IP for event bus host configuration
charts/selenium-grid/templates/event-bus-deployment.yaml
SE_EVENT_BUS_HOST
to use pod IP.hub-deployment.yaml
Use pod IP for hub host configuration
charts/selenium-grid/templates/hub-deployment.yaml
SE_HUB_HOST
to use pod IP.router-deployment.yaml
Use pod IP for router host configuration
charts/selenium-grid/templates/router-deployment.yaml
SE_ROUTER_HOST
to use pod IP.session-map-deployment.yaml
Use pod IP for session map host configuration
charts/selenium-grid/templates/session-map-deployment.yaml
SE_SESSIONS_HOST
to use pod IP.session-queue-deployment.yaml
Use pod IP for session queue host configuration
charts/selenium-grid/templates/session-queue-deployment.yaml
SE_SESSION_QUEUE_HOST
to use pod IP.1 files
CONFIGURATION.md
Update node service creation default setting
charts/selenium-grid/CONFIGURATION.md
false
.