feat: enable tracing observability in docker-compose and helm chart #2137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
feat: enable tracing observability in docker-compose and helm chart
Motivation and Context
Instead of passing arguments for OpenTelemetry via ENV var
JAVA_OPTS
(orSE_JAVA_OPTS
), it would be difficult to manage in case appending to an existing value. Create new ENV vars with prefixSE_OTEL_
for tracing configsBefore:
JAVA_OPTS="-Dotel.traces.exporter=jaeger -Dotel.exporter.jaeger.endpoint=http://jaegar:14250 -Dotel.resource.attributes=service.name=selenium-node-firefox"
After:
SE_OTEL_TRACES_EXPORTER
(default isotlp
) - pass value to-Dotel.traces.exporter=
SE_OTEL_EXPORTER_ENDPOINT=http://jaegar:4317
- pass value to-Dotel.exporter.${name}.endpoint=
In each component, by default, there is ENV
SE_OTEL_SERVICE_NAME
set its component name for argument-Dotel.resource.attributes=service.name=
Separate ENV vars for tracing configs also support better in helm chart template
Types of changes
Checklist