Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make var RECORD_VIDEO lowercase before comparison #2128

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

Doofus100500
Copy link
Contributor

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

RECORD_VIDEO lowercase before comparison

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VietND96
Copy link
Member

VietND96 commented Feb 7, 2024

Is this for the case in Python binding with input se:recordVideo: False, right?

@VietND96 VietND96 merged commit 6eab711 into SeleniumHQ:trunk Feb 7, 2024
8 checks passed
@VietND96
Copy link
Member

VietND96 commented Feb 7, 2024

Thank you, @Doofus100500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants