Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Update objects name convention with prefix is Chart RELEASENAME #2109 #2120

Merged

Conversation

Opvolger
Copy link
Contributor

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

[🚀 Feature]: Update objects name convention with prefix is Chart RELEASENAME #2109

Motivation and Context

.Release.Name prefix, so you can deploy multi charts in one namespace

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Opvolger Opvolger force-pushed the feature/releasename-prefix branch from d20bfc2 to 076bb62 Compare January 26, 2024 15:12
@Opvolger
Copy link
Contributor Author

I see I have to fix more tests :)

@VietND96
Copy link
Member

Looks like some mismatched name in Secret for HTTPS enabling

@VietND96 VietND96 changed the base branch from trunk to chart-REL-NAME January 29, 2024 09:44
@VietND96 VietND96 merged commit 5a5327e into SeleniumHQ:chart-REL-NAME Jan 29, 2024
6 of 8 checks passed
@VietND96
Copy link
Member

@Opvolger, thanks for your work! To collaborate the work with you, I merged your PR to a branch and continued on this before going to the trunk

VietND96 pushed a commit that referenced this pull request Feb 12, 2024
…ASENAME #2109 (#2120)

[feature]: Update objects name convention with prefix is Chart RELEASENAME #2109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants