Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): templating in name(Override) #2107

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

Opvolger
Copy link
Contributor

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

We need multiple selenium deployments in 1 namespace for development purposes. We use the release name and namespace in the (unique) naming convention to achieve this. Many charts we use can handle this, but this one cannot (yet). Hence these adjustments

Motivation and Context

We need multiple selenium deployments in 1 namespace

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2024

CLA assistant check
All committers have signed the CLA.

@VietND96
Copy link
Member

Hi @Opvolger , thank you!
Your situation is correct, the best practice is RELEASENAME should append to all the component name. I will have this patch in next chart release

@VietND96 VietND96 merged commit 3be1d42 into SeleniumHQ:trunk Jan 23, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants