feat(chart): Configuration extra scripts mount to container #2105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
feat(chart): Configuration extra scripts mount to container
Motivation and Context
Configuration extra scripts mount to container
This is supported for containers of browser node, video recorder and video uploader. By default, in these containers, there are scripts, config files implemented. In case you want to customize or replace them with your own implementation. Instead of forking the chart, use volume mount. Now, from your external files, you can insert them into ConfigMap via Helm CLI
--set-file
or compose them in your own YAML values file and pass to Helm CLI--values
when deploying chart. Any files name that you defined will be picked up into ConfigMap and mounted to the container.Via Helm CLI, you can pass your own files to particular config key. Note that, the file name contains dot
.
for file extension, it will impact to the key name convention in Helm CLI. In this case, be careful to escape the dot.
in the file name. For example a command in Unix:Files in
.extraScripts
will be mounted to the container with the same name within directory is defined in.extraScriptsDirectory
. For example, in the above config,nodePreStop.sh
will be mounted to/opt/selenium/nodePreStop.sh
in the node container.Types of changes
Checklist