feat(chart): Simplify to access Selenium Grid from outside of Kubernetes #2073
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
feat(chart): Simplify to access Selenium from outside of Kubernetes
Motivation and Context
Components service
NodePort
is set static via chartvalues.yaml
. NodePort will not be assigned randomly anymore. The user is able to change the values if wants to use another portEmbedded Ingress NGINX Controller as dependency chart and is enabled via
ingress-nginx.enabled=true
. Instead of the user having to find and download the ingress chart separately, the user can utilize this dependent chart and install it together with the Selenium Grid.Add config
ingress.ports.http
andingress.ports.https
to set specific ports in case your ingress not using default80
and443
. This is used to construct theSE_NODE_GRID_URL
which is important for Grid can be accessed from outside (e.g Distributed Nodes register to Hub, Grid UI, Session NoVNC/CDP URL, etc.Add config
global.K8S_PUBLIC_IP
for user can set the public IP of the host running the Kubernetes cluster, which is used to construct theSE_NODE_GRID_URL
in such use cases:ingress.hostname
. All the services will be exposed via the public IP is set inK8S_PUBLIC_IP
K8S_PUBLIC_IP
K8S_PUBLIC_IP
Some values files are used to test and deploy the Selenium Grid chart. Users can find them in
Types of changes
Checklist