feat(chart): Simplify to change log level in Kubernetes #2072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
feat(chart): Simplify to change log level in Kubernetes
Motivation and Context
Sometimes, a few questions related to Selenium Grid deployed on vendors cloud K8s service with issues like Node could not register to Hub, and relevant logs given something like
Then we get back to ask log level
FINE
to see lower debug logs for the problem troubleshooting.With the Selenium Grid chart, the user needs more steps to do that, find all components and set
extraEnvironmentVariables
withinSE_OPTS=--log-level FINE
Via this change, we try to simplify this config change by:
SE_LOG_LEVEL
to get input value, internally it would append value toSE_OPTS
and start the componentsSE_LOG_LEVEL
data is addedglobal.seleniumGrid.logLevel
is used to set a specific value.For example: If the user wants to change the log level to
FINE
, now it would be done byhelm upgrade -i test --set global.seleniumGrid.logLevel=FINE --values myConfigs.yaml selenium-grid-4.16.1-20231218.tgz
Added the test to ensure template renders config correctly
Types of changes
Checklist