Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Simplify to change log level in Kubernetes #2072

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

VietND96
Copy link
Member

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

feat(chart): Simplify to change log level in Kubernetes

Motivation and Context

Sometimes, a few questions related to Selenium Grid deployed on vendors cloud K8s service with issues like Node could not register to Hub, and relevant logs given something like

10:25:20.758 INFO [NodeServer.execute] - Started Selenium node 4.14.1 (revision 03f8ede370): http://10.244.4.8:5555
10:25:20.777 INFO [NodeServer$1.lambda$start$1] - Sending registration event...
10:25:30.781 INFO [NodeServer$1.lambda$start$1] - Sending registration event...
10:25:40.782 INFO [NodeServer$1.lambda$start$1] - Sending registration event...

Then we get back to ask log level FINE to see lower debug logs for the problem troubleshooting.
With the Selenium Grid chart, the user needs more steps to do that, find all components and set extraEnvironmentVariables within SE_OPTS=--log-level FINE

Via this change, we try to simplify this config change by:

For example: If the user wants to change the log level to FINE, now it would be done by
helm upgrade -i test --set global.seleniumGrid.logLevel=FINE --values myConfigs.yaml selenium-grid-4.16.1-20231218.tgz

Added the test to ensure template renders config correctly

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VietND96 VietND96 requested a review from diemol December 18, 2023 05:58
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @VietND96!

@VietND96 VietND96 merged commit 02e6af2 into SeleniumHQ:trunk Dec 18, 2023
6 checks passed
@VietND96 VietND96 self-assigned this Dec 18, 2023
@VietND96 VietND96 deleted the chart-PR01 branch December 20, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants