Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add build-arg to get based version from Makefile #2049

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Dec 6, 2023

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Add build-arg to get based version from Makefile

Motivation and Context

Partial support CI build the images on top of Selenium Nightly build
BASE_RELEASE=nightly BASE_VERSION=4.16.0-SNAPSHOT make build

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VietND96 VietND96 requested a review from diemol December 6, 2023 08:24
@VietND96 VietND96 self-assigned this Dec 6, 2023
@VietND96 VietND96 merged commit da15922 into SeleniumHQ:trunk Dec 6, 2023
6 checks passed
@VietND96 VietND96 deleted the docker-image branch December 6, 2023 10:39
@VietND96 VietND96 changed the title Add build-arg to get based version from Makefile build: Add build-arg to get based version from Makefile Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant