feat(chart): Add default annotations for ingress nginx controller #2047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
feat(chart): Add default annotations for ingress nginx controller
Motivation and Context
By default, ingress is enabled without annotations set. If NGINX ingress controller is used, you need to set few annotations to override the default timeout values to avoid 504 errors (see #1808). Since in Selenium Grid the default of
SE_NODE_SESSION_TIMEOUT
andSE_SESSION_REQUEST_TIMEOUT
is300
seconds.In order to make user experience better, there are few annotations will be set by default if NGINX ingress controller is used. Mostly relates to timeouts and buffer sizes.
If you are not using NGINX ingress controller, you can disable these default annotations by setting
ingress.nginx
tonil
(aka null) via Helm CLI--set ingress.nginx=null
) or via an override-values.yaml as below:Similarly, if you want to disable a sub-config of
ingress.nginx
. For example:--set ingress.nginx.proxyBuffer=null
)You are also able to combine using both default annotations and your own annotations in
ingress.annotations
. Duplicated keys will be merged strategy overwrite with your own annotations iningress.annotations
take precedence.List mapping of chart values and default annotation(s)
Types of changes
Checklist