fix(chart): Improve templates in the section videoRecorder #1987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Improve chart templates in the section videoRecorder after #1881
Motivation and Context
imageTag
default valuelatest
toffmpeg-6.0-YYYYMMDD
to align within project.5666
to9000
. Since by default, video container exposes 9000 in Dockerfile.startupProbe
andlivenessProbe
for the video container to template. Since via ConfigMap and script video_ready.py, the user can extend custom APIs and use them to check video container startup or liveness. (Refer to a sample)extraVolumeMounts
,extraVolumes
, its default value, and sample reference in comment lines.video
anduploader
, 2 mount points with namevideo
andvideo-scripts
are set static values in the template. If a user wants to modify another way to persist and share that path in container or mount video scripts to their custom ConfigMap, etc. It seems difficult to do via chartvalues.yaml
.Improve: via _helpers.tpl, create a template for initial default configs. Create another template to combine the config
extraVolumeMounts
,extraVolumes
input from user and default configs required. Based on the unique key of config, if it already existed in the extra part, which is redefined by the user, it would take precedence and the default config will be ignoredtpl
function in a few lines, which adds extra configs from chartvalues.yaml
to apply template to a set of data . For example, data contains Helm variables likeJAVA_OPTS: "-Dotel.traces.exporter=jaeger -Dotel.exporter.jaeger.endpoint=http://{{ .Release.Name }}-jaeger-all-in-one-headless:14250
Types of changes
Checklist