Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump images to 4.14.0 #1970

Merged
merged 11 commits into from
Oct 16, 2023
Merged

Bump images to 4.14.0 #1970

merged 11 commits into from
Oct 16, 2023

Conversation

luisfcorreia
Copy link
Contributor

Bump images to 4.14.0

Removed selenium-http-jdk-client-xxx.jar from image as we're now using Java 11

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

update Dockerfile
Update bootstrap.sh
Update Chart.yaml
Update Chart.yaml
Update CHANGELOG.md
@luisfcorreia luisfcorreia requested a review from diemol October 10, 2023 09:18
@amardeep2006
Copy link
Contributor

amardeep2006 commented Oct 11, 2023

hi @luisfcorreia I see multiple reference to /opt/selenium/selenium-http-jdk-client.jar in NodeBase/start-selenium-node.sh . It is present in almost every Image (Hub,Router etc. etc.)
Can that cause some issue on runtime ?
Few references for example :
https://github.com/SeleniumHQ/docker-selenium/blob/69d9349c6eefcdcaa9b899547caceb86f9f7998d/NodeBase/start-selenium-node.sh#L39C1-L39C10

java ${JAVA_OPTS:-$SE_JAVA_OPTS} -Dwebdriver.http.factory=jdk-http-client \

@luisfcorreia
Copy link
Contributor Author

yes @amardeep2006, you may be right, I'll look into it

Base/Dockerfile Outdated Show resolved Hide resolved
charts/selenium-grid/CHANGELOG.md Outdated Show resolved Hide resolved
charts/selenium-grid/Chart.yaml Outdated Show resolved Hide resolved
Update Dockerfile
Update CHANGELOG.md
Update Chart.yaml
@luisfcorreia
Copy link
Contributor Author

Proposed changes applied

@baflQA
Copy link
Contributor

baflQA commented Oct 16, 2023

Btw, there is already a newer version of Selenium - [4.14.1]

@luisfcorreia
Copy link
Contributor Author

Forgot there is a new Selenium Java release in the meantime (thanks Bartek)

charts/selenium-grid/CHANGELOG.md Outdated Show resolved Hide resolved
charts/selenium-grid/Chart.yaml Outdated Show resolved Hide resolved
@luisfcorreia
Copy link
Contributor Author

Reverting as requested

@luisfcorreia luisfcorreia requested a review from diemol October 16, 2023 11:54
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for CI to pass and then let's merge.

@diemol diemol merged commit cefee2a into SeleniumHQ:trunk Oct 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants