Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace 777 by 775 and change file owner to seluser #1963

Closed
wants to merge 2 commits into from
Closed

replace 777 by 775 and change file owner to seluser #1963

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5056229
replace 777 by 775 and change file owner to seluser
eravion Oct 2, 2023
8cbeccc
Merge branch 'trunk' into eravion-patch-1
eravion Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Base/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ ENV HOME=/home/seluser
# Add Grid check script
#======================================
COPY check-grid.sh entry_point.sh /opt/bin/
# change right for /opt/bin*.sh file
RUN chmod 775 /opt/bin/*.sh
Comment on lines +64 to +65
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the COPY with chmod as mentioned in the Docker documentation https://docs.docker.com/engine/reference/builder/#copy


#======================================
# Add Supervisor configuration file
Expand All @@ -72,7 +74,10 @@ COPY supervisord.conf /etc
#==========
RUN mkdir -p /opt/selenium /opt/selenium/assets /var/run/supervisor /var/log/supervisor \
&& touch /opt/selenium/config.toml \
&& chmod -R 777 /opt/selenium /opt/selenium/assets /var/run/supervisor /var/log/supervisor /etc/passwd \
# && chown seluser:seluser /var/run/supervisor /var/log/supervisor /opt/selenium /etc/passwd \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you keeping this commented line?

&& chown seluser:seluser /var/run/supervisor /var/log/supervisor /opt/selenium \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove /etc/passwd?

&& chmod -R 775 /opt/selenium /opt/selenium/assets /var/run/supervisor /var/log/supervisor /etc/passwd \
&& chmod -R 644 /etc/supervisord.conf \
&& wget --no-verbose https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.13.0/selenium-server-4.13.0.jar \
-O /opt/selenium/selenium-server.jar \
&& wget --no-verbose https://repo1.maven.org/maven2/org/seleniumhq/selenium/selenium-http-jdk-client/4.13.0/selenium-http-jdk-client-4.13.0.jar \
Expand Down