Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding VNC_PASSWORD to configure VNC password #1840

Merged
merged 1 commit into from
May 2, 2023
Merged

Adding VNC_PASSWORD to configure VNC password #1840

merged 1 commit into from
May 2, 2023

Conversation

serlank
Copy link
Contributor

@serlank serlank commented May 2, 2023

Description

Adding the SE_VNC_PASSWORD environment variable to allow a custom VNC password to be configured.

Motivation and Context

I have a similar requirement as described in #1772, I want the ability to control the VNC server password, without having to rebuild docker images.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented May 2, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

diemol
diemol approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@diemol diemol merged commit b219fc6 into SeleniumHQ:trunk May 2, 2023
@diemol
Copy link
Member

diemol commented May 2, 2023

I'll wait for another PR to get merged and then do a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serlank @CLAassistant @diemol