Refine lang setting #1778
Merged
Refine lang setting #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diemol - could you give this a look when you have time to make sure I am taking the right approach to make sure the env variable is set in the dynamic node containers? |
diemol
reviewed
Jan 25, 2023
diemol
force-pushed
the
refine_lang_setting
branch
from
bcd581b to
7619a63
Compare
diemol
approved these changes
Jan 30, 2023
The PR looks good. However, I am still waiting for your reply on this question, @jsa34. |
|
Apologies - I haven't had a chance yet, but will try to today
…________________________________
From: Diego Molina ***@***.***>
Sent: 30 January 2023 10:18
To: SeleniumHQ/docker-selenium ***@***.***>
Cc: Jason Allen ***@***.***>; Mention ***@***.***>
Subject: Re: [SeleniumHQ/docker-selenium] Refine lang setting (PR #1778)
This is quite tricky to test. The script looks fine to me.
Have you built the images locally to test it? If you tell me that it works, I'd be happy to merge it and release.
The PR looks good. However, I am still waiting for your reply on this question, @jsa34<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjsa34&data=05%7C01%7Cjsa34%40universityofcambridgecloud.onmicrosoft.com%7C59caf5d7baee40207cf908db02ab668e%7C49a50445bdfa4b79ade3547b4f3986e9%7C1%7C0%7C638106707414326751%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=EEpCG9OVPXdSRMEQV8dG77FoTfz6M9kjuNJverEJr18%3D&reserved=0>.
|
|
👍 |
|
Built images locally (hopefully correctly as I have to use a Windows machine with WSL2) and looks ok.
I could only check the standalone locally, but logically should be fine with dynamic grid.
…________________________________
From: Diego Molina ***@***.***>
Sent: 30 January 2023 10:20
To: SeleniumHQ/docker-selenium ***@***.***>
Cc: Jason Allen ***@***.***>; Mention ***@***.***>
Subject: Re: [SeleniumHQ/docker-selenium] Refine lang setting (PR #1778)
👍
Please let me know and I'd be happy to do a release after that.
|
This was referenced Feb 13, 2023
prashanth-volvocars
pushed a commit
to prashanth-volvocars/docker-selenium
that referenced
this pull request
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Sets the LANGUAGE env var as part of the binary wrapper script, instead of outside it,
Motivation and Context
Resolves #1750.
Previous attempt didn't permeate to the node container in dynamic grid setup.
Types of changes
Checklist