Set lang chromiumdriver attribute as an environment var to resolve th… #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…is not taking affect in current grid images
diemol
force-pushed
the
setting_lang_var_for_chromium_drivers
branch
from
941a8fb to
a756313
Compare
|
@jsa34 can you please sign the CLA so I can merge this? |
|
Of course! All done :) |
prashanth-volvocars
pushed a commit
to prashanth-volvocars/docker-selenium
that referenced
this pull request
Jun 29, 2023
SeleniumHQ#1751) Set lang chromiumdriver attribute as an environment var to resolve this not taking affect in current grid images [deploy]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is not taking affect in current grid images
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Resolves #1750
Motivation and Context
Need to be able to change language of browser when running tests (chromedriver settings currently don't work)
Types of changes
Checklist