Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster access to noVNC #1748

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Faster access to noVNC #1748

merged 2 commits into from
Dec 19, 2022

Conversation

nwtgck
Copy link
Contributor

@nwtgck nwtgck commented Dec 18, 2022

Thank you so much for the wonderful project!

I slightly changed the README.

Access to http://localhost:7900/?autoconnect=1&password=secret is faster without typing the password and clicking the button.

Demo

demo.mp4

noVNC document

The query parameter is documented on noVNC.
image

https://github.com/novnc/noVNC/blob/4fb2d6c497dc2e307400ff581f9292758c709b40/docs/EMBEDDING.md?plain=1#L31-L48


Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

To improve user experience for document users.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Dec 18, 2022

CLA assistant check
All committers have signed the CLA.

@nwtgck
Copy link
Contributor Author

nwtgck commented Dec 18, 2022

I would like to add &resize=scale because I always set "Local Scaling" in the Scaling Mode setting.

Could I change this in the PR?

@diemol
Copy link
Member

diemol commented Dec 18, 2022

I would like to add &resize=scale because I always set "Local Scaling" in the Scaling Mode setting.

Could I change this in the PR?

Sure. Please also sign the CLA so we can merge this.

@nwtgck
Copy link
Contributor Author

nwtgck commented Dec 19, 2022

I added it and signed.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @nwtgck!

@diemol diemol merged commit 21e7068 into SeleniumHQ:trunk Dec 19, 2022
@nwtgck nwtgck deleted the patch-1 branch December 19, 2022 10:15
prashanth-volvocars pushed a commit to prashanth-volvocars/docker-selenium that referenced this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants