Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grid][chart] Allows users to turn off Deployment creation for Nodes #1709

Merged
merged 2 commits into from
Oct 31, 2022
Merged

[grid][chart] Allows users to turn off Deployment creation for Nodes #1709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42d8b91
[grid][chart] Allows users to turn of Deployment creation for Nodes
mhnaeem Oct 27, 2022
ffdf2b3
Update the Changelog and bump chart version
mhnaeem Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions charts/selenium-grid/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

All notable changes to this helm chart will be documented in this file.

## :heavy_check_mark: 0.13.0

### Added
- Added support to disable Chrome, Edge, and Firefox Deployment using `deploymentEnabled`

## :heavy_check_mark: 0.12.2

### Changed
Expand Down
2 changes: 1 addition & 1 deletion charts/selenium-grid/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ apiVersion: v2
name: selenium-grid
description: A Helm chart for creating a Selenium Grid Server in Kubernetes
type: application
version: 0.12.2
version: 0.13.0
appVersion: 4.5.3-20221024
icon: https://github.com/SeleniumHQ/docker-selenium/raw/trunk/logo.png
3 changes: 3 additions & 0 deletions charts/selenium-grid/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ This table contains the configuration parameters of the chart and their default
| `ingress.tls` | `[]` | TLS backend configuration for ingress resource |
| `busConfigMap.annotations` | `{}` | Custom annotations for configmap |
| `chromeNode.enabled` | `true` | Enable chrome nodes |
| `chromeNode.deploymentEnabled` | `true` | Enable creation of Deployment for chrome nodes |
| `chromeNode.replicas` | `1` | Number of chrome nodes |
| `chromeNode.imageName` | `selenium/node-chrome` | Image of chrome nodes |
| `chromeNode.imageTag` | `4.5.3-20221024` | Image of chrome nodes |
Expand Down Expand Up @@ -95,6 +96,7 @@ This table contains the configuration parameters of the chart and their default
| `chromeNode.extraVolumeMounts` | `[]` | Extra mounts of declared ExtraVolumes into pod |
| `chromeNode.extraVolumes` | `[]` | Extra Volumes declarations to be used in the pod (can be any supported volume type: ConfigMap, Secret, PVC, NFS, etc.) |
| `firefoxNode.enabled` | `true` | Enable firefox nodes |
| `firefoxNode.deploymentEnabled` | `true` | Enable creation of Deployment for firefox nodes |
| `firefoxNode.replicas` | `1` | Number of firefox nodes |
| `firefoxNode.imageName` | `selenium/node-firefox` | Image of firefox nodes |
| `firefoxNode.imageTag` | `4.5.3-20221024` | Image of firefox nodes |
Expand Down Expand Up @@ -122,6 +124,7 @@ This table contains the configuration parameters of the chart and their default
| `firefoxNode.extraVolumeMounts` | `[]` | Extra mounts of declared ExtraVolumes into pod |
| `firefoxNode.extraVolumes` | `[]` | Extra Volumes declarations to be used in the pod (can be any supported volume type: ConfigMap, Secret, PVC, NFS, etc.) |
| `edgeNode.enabled` | `true` | Enable edge nodes |
| `edgeNode.deploymentEnabled` | `true` | Enable creation of Deployment for edge nodes |
| `edgeNode.replicas` | `1` | Number of edge nodes |
| `edgeNode.imageName` | `selenium/node-edge` | Image of edge nodes |
| `edgeNode.imageTag` | `4.5.3-20221024` | Image of edge nodes |
Expand Down
2 changes: 1 addition & 1 deletion charts/selenium-grid/templates/chrome-node-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.chromeNode.enabled }}
{{- if and .Values.chromeNode.enabled .Values.chromeNode.deploymentEnabled }}
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
2 changes: 1 addition & 1 deletion charts/selenium-grid/templates/edge-node-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.edgeNode.enabled }}
{{- if and .Values.edgeNode.enabled .Values.edgeNode.deploymentEnabled }}
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
2 changes: 1 addition & 1 deletion charts/selenium-grid/templates/firefox-node-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.firefoxNode.enabled }}
{{- if and .Values.firefoxNode.enabled .Values.firefoxNode.deploymentEnabled }}
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
18 changes: 18 additions & 0 deletions charts/selenium-grid/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,12 @@ hub:
chromeNode:
# Enable chrome nodes
enabled: true

# Enable creation of Deployment
# true (default) - if you want long living pods
# false - for provisioning your own custom type such as Jobs
deploymentEnabled: true

# Number of chrome nodes
replicas: 1
# Image of chrome nodes
Expand Down Expand Up @@ -396,6 +402,12 @@ chromeNode:
firefoxNode:
# Enable firefox nodes
enabled: true

# Enable creation of Deployment
# true (default) - if you want long living pods
# false - for provisioning your own custom type such as Jobs
deploymentEnabled: true

# Number of firefox nodes
replicas: 1
# Image of firefox nodes
Expand Down Expand Up @@ -502,6 +514,12 @@ firefoxNode:
edgeNode:
# Enable edge nodes
enabled: true

# Enable creation of Deployment
# true (default) - if you want long living pods
# false - for provisioning your own custom type such as Jobs
deploymentEnabled: true

# Number of edge nodes
replicas: 1
# Image of edge nodes
Expand Down