Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable autorestart for vnc and other video-related services #1624

Merged

Conversation

AutomationD
Copy link
Contributor

@AutomationD AutomationD commented Jul 5, 2022

Description

Enabled autorestart in vnc-related supervisor services.

Motivation and Context

When a VNC process crashes there is no way to restart it, and it breaks video capabilities. I don't see any downside of enabling it, as there is also a circuitbreaker which stops restarts after 3 tries.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

asciicast

@AutomationD
Copy link
Contributor Author

@diemol

  1. I've pushed startretries changes
  2. I've updated ascicinema test showing that a vnc process is recreated under a new pid 808
    Here's a plan log of the test:
❯ docker exec -it 41e0c6797a94 /bin/bash
seluser@41e0c6797a94:/$ supervisorctl status
novnc                            RUNNING   pid 12, uptime 0:00:08
selenium-node                    RUNNING   pid 15, uptime 0:00:08
vnc                              RUNNING   pid 11, uptime 0:00:08
xvfb                             RUNNING   pid 10, uptime 0:00:09
seluser@41e0c6797a94:/$ kill -9 11
seluser@41e0c6797a94:/$ supervisorctl status
novnc                            RUNNING   pid 12, uptime 0:00:19
selenium-node                    RUNNING   pid 15, uptime 0:00:19
vnc                              RUNNING   pid 808, uptime 0:00:01
xvfb                             RUNNING   pid 10, uptime 0:00:20

- Enable autorestart for vnc and other video-related services
- Switch back to defaults in startsecs (1)
- Switch back to defaults in startretries (3)
@AutomationD AutomationD force-pushed the feature/supervisor-services-autorestart branch from d56f1a0 to 3925d5f Compare July 6, 2022 11:23
@diemol diemol merged commit f8cb704 into SeleniumHQ:trunk Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants