Helm: ability to specify image pull secrets (#1619) #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added global value `global.seleniumGrid.imagePullSecret` Added per component override `component.imagePullSecret` Updated readme Bumped chart version to 0.7.0
|
|
|
Hi @zmconnelly, I had to bump the chart version to acknowledge the recent image release. Can you please update your fork and then we can merge? |
Added global value `global.seleniumGrid.imagePullSecret` Added per component override `component.imagePullSecret` Updated readme Bumped chart version to 0.7.0
…nnelly/docker-selenium into 1619-helm-image-pull-policy
|
@diemol done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added global value
global.seleniumGrid.imagePullSecretAdded per component override
component.imagePullSecretUpdated readme
Bumped chart version to 0.7.0
Motivation and Context
Allows users to deploy images from a private repository rather than dockerhub.
Types of changes
Checklist