Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env vars #1603

Merged
merged 9 commits into from
Jun 16, 2022
Merged

Env vars #1603

merged 9 commits into from
Jun 16, 2022

Conversation

diemol
Copy link
Member

@diemol diemol commented Jun 15, 2022

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

This prefixes all environment variables with SE_ in order to make it simple for Dynamic Grid to identify them and pass them along to the child containers.

Motivation and Context

So it is possible to configure the child containers in Dynamic Grid. Please note, the Grid code still needs to read the env vars, which will be done in the upstream repository.

This PR helps with #1319

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol diemol merged commit 3c74143 into trunk Jun 16, 2022
@diemol diemol deleted the env-vars branch June 16, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant