Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod priority class to helm chart and icon #1594

Merged
merged 3 commits into from
Jul 1, 2022
Merged

Add pod priority class to helm chart and icon #1594

merged 3 commits into from
Jul 1, 2022

Conversation

cablespaghetti
Copy link

Description

Add priorityClassName option for each deployment and add an icon to the Helm chart.

Motivation and Context

We have had some issues with pods getting preempted in the middle of running a test which causes a test failure. Setting a higher priority for pods should reduce the chance of this happening.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2022

CLA assistant check
All committers have signed the CLA.

@diemol
Copy link
Member

diemol commented Jul 1, 2022

Could you please update your fork and also update the values in Chart.yaml?

@cablespaghetti
Copy link
Author

Done 👍

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @cablespaghetti

@diemol diemol merged commit e35f3aa into SeleniumHQ:trunk Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants