Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger chart release only on changes in the charts directory #1582

Merged
merged 1 commit into from
May 25, 2022
Merged

Trigger chart release only on changes in the charts directory #1582

merged 1 commit into from
May 25, 2022

Conversation

den-is
Copy link
Contributor

@den-is den-is commented May 25, 2022

Motivation and Context

I would like to suggest triggering chart-releaser action only on changes in the charts directory.
I don't see any other logic that triggers chart publishing on any push to the trunk that also updates Chart.yaml with a new version automatically.
So IMHO, Chart version is updated and pushed to trunk manually (PR merged), so the chart needs release only when anything in the charts dir changes.

Feel free to discard, if that logic doesn't fit your workflow :)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@den-is, makes a lot of sense, thank you!

@diemol diemol merged commit 8dd2ae5 into SeleniumHQ:trunk May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants