Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to insert entire configmap/secret into env. #1521

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 5, 2022

Description

This adds a new variable to all components of the Helm Chart. extraEnvFrom – it allows inserting an entire configMap or secret via envFrom into the environment.

Motivation and Context

It is cleaner and simpler to source an entire configMap into the environment, instead of inserting each variable individually. Especially if you have default env. Vars you want to always insert like proxy settings or similar.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Mar 5, 2022

CLA assistant check
All committers have signed the CLA.

@ghost ghost force-pushed the feature/add-extra-envfrom branch from c12e281 to a48fa8f Compare March 5, 2022 17:01
@diemol diemol requested a review from ilpianista March 12, 2022 00:57
Copy link
Contributor

@ilpianista ilpianista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@diemol
Copy link
Member

diemol commented Mar 14, 2022

Thank you for reviewing, @ilpianista!

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @xcalizorz!

@diemol diemol merged commit db98b37 into SeleniumHQ:trunk Mar 14, 2022
@ghost ghost deleted the feature/add-extra-envfrom branch March 14, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants