Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using xvfb-run to expose display via tcp #1110

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Using xvfb-run to expose display via tcp #1110

merged 1 commit into from
Sep 17, 2020

Conversation

diemol
Copy link
Member

@diemol diemol commented Sep 17, 2020

This will allow another container to attach
itself to the exposed display, and potentially
record the stream.

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

This changes slighlty how xvfb is started, and allows exposing the display via tcp.

Motivation and Context

If the display can be accessed via tcp, we can potentially have another container running with ffmpeg and record the display.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This will allow another container to attach
itself to the exposed display, and potentially
record the stream.
@diemol diemol merged commit 5a28238 into trunk Sep 17, 2020
@diemol diemol deleted the use-xvfb-run branch September 17, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant