Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: Simple document change for getting Helm charts working #1810

Closed
indeed-ted opened this issue Mar 17, 2023 · 6 comments · Fixed by #1994
Closed

[🐛 Bug]: Simple document change for getting Helm charts working #1810

indeed-ted opened this issue Mar 17, 2023 · 6 comments · Fixed by #1994

Comments

@indeed-ted
Copy link

indeed-ted commented Mar 17, 2023

What happened?

I was going through the helm chart steps here: https://github.com/SeleniumHQ/docker-selenium/blob/trunk/charts/selenium-grid/README.md

Everything worked and initialized fine in helm/kubectl, but two commands/steps were missing to get the ingress url (default is selenium-grid.local) to be useful. I am new to all of this and I kept getting this:

$ ping selenium-grid.local
ping: selenium-grid.local: Name or service not known

And therefore, when trying to create a RemoteWebDriver using the ingress URL like this in Java:

        String gridIngressUrl = "http://selenium-grid.local";
        ChromeOptions caps = new ChromeOptions();
        RemoteWebDriver driver = new RemoteWebDriver(new URL(gridIngressUrl), caps);

was giving me this exception:
Caused by: java.net.UnknownHostException: selenium-grid.local.: Name or service not known

I figured out these 2 steps were required to get the ingress urls to work:

Step 1: Verify ingress config, run: kubectl get ingress

$ kubectl get ingress
NAME               CLASS   HOSTS                     ADDRESS        PORTS   AGE
selenium-ingress   nginx   selenium-grid.local       192.168.49.2   80      45m

Step 2: Add the IP and host name to the local host file in /etc/hosts, like:
192.168.49.2 selenium-grid.local

It would be very useful to add it to this README: https://github.com/SeleniumHQ/docker-selenium/blob/trunk/charts/selenium-grid/README.md

Command used to start Selenium Grid with Docker

helm install selenium-grid docker-selenium/selenium-grid

Relevant log output

$ ping selenium-grid.local
ping: selenium-grid.local: Name or service not known

Operating System

Ubuntu 20.04.6 LTS (GNU/Linux 5.15.0-1031-aws x86_64)

Docker Selenium version (tag)

$ helm list 
NAME         	NAMESPACE	REVISION	UPDATED                                	STATUS  	CHART               	APP VERSION
selenium-grid	default  	1       	2023-03-16 18:27:29.187525806 -0500 CDT	deployed	selenium-grid-0.15.4	4.8.1-20230306
@github-actions
Copy link

@indeed-ted, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@diemol
Copy link
Member

diemol commented Mar 17, 2023

Would you like to send us a pull request with this?

@github-actions
Copy link

This issue is looking for contributors.

Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested.

VietND96 added a commit to NDViet/docker-selenium that referenced this issue Nov 6, 2023
diemol pushed a commit that referenced this issue Nov 6, 2023
* Add chart parameter ingress.paths to configure custom paths

Signed-off-by: Viet Nguyen Duc <[email protected]>

* #1810 Update dafault value for ingress.hostname

Signed-off-by: Viet Nguyen Duc <[email protected]>

* Update chart README for config parameters basicAuth.

Signed-off-by: Viet Nguyen Duc <[email protected]>

---------

Signed-off-by: Viet Nguyen Duc <[email protected]>
@VietND96
Copy link
Member

VietND96 commented Nov 7, 2023

Via PR #1994, I have updated README with your suggested steps.
Also, I updated default value of ingress.hostname to empty. It would act as a catch-all for requests without a specific hostname. It is suitable for beginner users with a basic setup locally (without hostname configured). The Grid UI view can be accessed via the host IP. Advanced users they can change another hostname and do extra configs accordingly.

@diemol
Copy link
Member

diemol commented Nov 8, 2023

Thank you, @VietND96!

@diemol diemol closed this as completed Nov 8, 2023
Copy link

github-actions bot commented Dec 9, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants