Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Allow users to turn off creation for Deployment in k8s #1708

Closed
mhnaeem opened this issue Oct 27, 2022 · 0 comments · Fixed by #1709
Closed

[🚀 Feature]: Allow users to turn off creation for Deployment in k8s #1708

mhnaeem opened this issue Oct 27, 2022 · 0 comments · Fixed by #1709

Comments

@mhnaeem
Copy link
Contributor

mhnaeem commented Oct 27, 2022

Feature and motivation

I would like to stop the creation of Deployment type in my Kubernetes cluster and instead use a custom resource type or Job. This feature will provide users with a flag to turn off the creation of browser node deployments.

Usage example

I want to use ScaledJob by Keda instead of the default Deployment but I get multiple Nodes, ones from Deployments and others from Jobs which is confusing.

mhnaeem added a commit to mhnaeem/docker-selenium that referenced this issue Oct 27, 2022
This change introduces a new value called `deploymentEnabled` for each of the node browsers,
if the value is set to `true` Deployments will be created for each of the respective nodes however if `false` no Deployments will be created.

This will allow users to turn of creation of the default deployments and to use other resource types instead such as jobs.

Fixes SeleniumHQ#1708
diemol pushed a commit that referenced this issue Oct 31, 2022
…1709)

* [grid][chart] Allows users to turn of Deployment creation for Nodes

This change introduces a new value called `deploymentEnabled` for each of the node browsers,
if the value is set to `true` Deployments will be created for each of the respective nodes however if `false` no Deployments will be created.

This will allow users to turn of creation of the default deployments and to use other resource types instead such as jobs.

Fixes #1708

* Update the Changelog and bump chart version
MantasGurskis pushed a commit to hostinger/docker-selenium that referenced this issue Apr 26, 2023
…eleniumHQ#1709)

* [grid][chart] Allows users to turn of Deployment creation for Nodes

This change introduces a new value called `deploymentEnabled` for each of the node browsers,
if the value is set to `true` Deployments will be created for each of the respective nodes however if `false` no Deployments will be created.

This will allow users to turn of creation of the default deployments and to use other resource types instead such as jobs.

Fixes SeleniumHQ#1708

* Update the Changelog and bump chart version
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant