Skip to content

Commit

Permalink
Fixed parsing problem with msedgedriver version in release notes (#1657)
Browse files Browse the repository at this point in the history
Fixed parsing problem with msedgedriver version in release notes generator script and docker image tagging script.
  • Loading branch information
jamesmortensen authored Aug 15, 2022
1 parent 46716f5 commit fe89258
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion generate_release_notes.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ git --no-pager log "${LATEST_TAG}...${HEAD_BRANCH}" --pretty=format:"* [\`%h\`](
CHROME_VERSION=$(docker run --rm selenium/node-chrome:${TAG_VERSION} google-chrome --version | awk '{print $3}')
EDGE_VERSION=$(docker run --rm selenium/node-edge:${TAG_VERSION} microsoft-edge --version | awk '{print $3}')
CHROMEDRIVER_VERSION=$(docker run --rm selenium/node-chrome:${TAG_VERSION} chromedriver --version | awk '{print $2}')
EDGEDRIVER_VERSION=$(docker run --rm selenium/node-edge:${TAG_VERSION} msedgedriver --version | awk '{print $2}')
EDGEDRIVER_VERSION=$(docker run --rm selenium/node-edge:${TAG_VERSION} msedgedriver --version | awk '{print $4}')
FIREFOX_VERSION=$(docker run --rm selenium/node-firefox:${TAG_VERSION} firefox --version | awk '{print $3}')
GECKODRIVER_VERSION=$(docker run --rm selenium/node-firefox:${TAG_VERSION} geckodriver --version | awk 'NR==1{print $2}')
FFMPEG_VERSION=$(docker run --entrypoint="" --rm selenium/video:ffmpeg-4.3.1-${BUILD_DATE} ffmpeg -version | awk '{print $3}' | head -n 1)
Expand Down
2 changes: 1 addition & 1 deletion tag_and_push_browser_images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ edge)
EDGE_SHORT_VERSION="$(short_version ${EDGE_VERSION})"
echo "Short Edge version -> "${EDGE_SHORT_VERSION}

EDGEDRIVER_VERSION=$(docker run --rm selenium/node-edge:${TAG_VERSION} msedgedriver --version | awk '{print $2}')
EDGEDRIVER_VERSION=$(docker run --rm selenium/node-edge:${TAG_VERSION} msedgedriver --version | awk '{print $4}')
echo "EdgeDriver version -> "${EDGEDRIVER_VERSION}
EDGEDRIVER_SHORT_VERSION="$(short_version ${EDGEDRIVER_VERSION})"
echo "Short EdgeDriver version -> "${EDGEDRIVER_SHORT_VERSION}
Expand Down

0 comments on commit fe89258

Please sign in to comment.