Add option to inject sidecars into Node Pods

SeleniumHQ · Sep 11, 2023 · 1090743 · 1090743
1 parent 427bf91
commit 1090743
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/charts/selenium-grid/README.md b/charts/selenium-grid/README.md
@@ -139,6 +139,7 @@ This table contains the configuration parameters of the chart and their default
 | `chromeNode.hpa.browserName`                | `chrome`                                    | BrowserName from the capability                                                                                            |
 | `chromeNode.hpa.browserVersion`             | ``                                          | BrowserVersion from the capability                                                                                         |
 | `chromeNode.maxReplicaCount`                | `8`                                         | Max number of replicas that this browsernode can auto scale up to                                                          |
+| `chromeNode.sidecars`                       | `[]`                                        | Extra sidecars to be used in the chrome-node pods                                                                          |
 | `firefoxNode.enabled`                       | `true`                                      | Enable firefox nodes                                                                                                       |
 | `firefoxNode.deploymentEnabled`             | `true`                                      | Enable creation of Deployment for firefox nodes                                                                            |
 | `firefoxNode.replicas`                      | `1`                                         | Number of firefox nodes                                                                                                    |
@@ -174,6 +175,7 @@ This table contains the configuration parameters of the chart and their default
 | `firefoxNode.hpa.browserName`               | `firefox`                                   | BrowserName from the capability                                                                                            |
 | `firefoxNode.hpa.browserVersion`            | ``                                          | BrowserVersion from the capability                                                                                         |
 | `firefoxNode.maxReplicaCount`               | `8`                                         | Max number of replicas that this browsernode can auto scale up to                                                          |
+| `firefoxNode.sidecars`                      | `[]`                                        | Extra sidecars to be used in the firefox-node pods                                                                         |
 | `edgeNode.enabled`                          | `true`                                      | Enable edge nodes                                                                                                          |
 | `edgeNode.deploymentEnabled`                | `true`                                      | Enable creation of Deployment for edge nodes                                                                               |
 | `edgeNode.replicas`                         | `1`                                         | Number of edge nodes                                                                                                       |
@@ -209,6 +211,7 @@ This table contains the configuration parameters of the chart and their default
 | `edgeNode.hpa.browserName`                  | `edge`                                      | BrowserName from the capability                                                                                            |
 | `edgeNode.hpa.browserVersion`               | ``                                          | BrowserVersion from the capability                                                                                         |
 | `edgeNode.maxReplicaCount`                  | `8`                                         | Max number of replicas that this browsernode can auto scale up to                                                          |
+| `edgeNode.sidecars`                         | `[]`                                        | Extra sidecars to be used in the edge-node pods                                                                            |
 | `customLabels`                              | `{}`                                        | Custom labels for k8s resources                                                                                            |
 | `customLabels`                              | `{}`                                        | Custom labels for k8s resources                                                                                            |
 

diff --git a/charts/selenium-grid/templates/_helpers.tpl b/charts/selenium-grid/templates/_helpers.tpl
@@ -165,6 +165,9 @@ template:
       {{- with .node.livenessProbe }}
         livenessProbe: {{- toYaml . | nindent 10 }}
       {{- end }}
+    {{- if .node.sidecars }}
+      {{- toYaml .node.sidecars | nindent 6 }}
+    {{- end }}
   {{- if or .Values.global.seleniumGrid.imagePullSecret .node.imagePullSecret }}
     imagePullSecrets:
       - name: {{ default .Values.global.seleniumGrid.imagePullSecret .node.imagePullSecret }}

diff --git a/charts/selenium-grid/values.yaml b/charts/selenium-grid/values.yaml
@@ -478,6 +478,12 @@ chromeNode:
     # browserVersion: '91.0' # Optional. Only required when supporting multiple versions of browser in your Selenium Grid.
     unsafeSsl : 'true' # Optional
 
+  # It is used to add a sidecars proxy in the same pod of the browser node.
+  # It means it will add a new container to the deployment itself.
+  # It should be set using the --set-json option
+  sidecars: []
+
+
 # Configuration for firefox nodes
 firefoxNode:
   # Enable firefox nodes
@@ -591,6 +597,11 @@ firefoxNode:
     url: '{{ include "seleniumGrid.graphqlURL" . }}'
     browserName: firefox
 
+  # It is used to add a sidecars proxy in the same pod of the browser node.
+  # It means it will add a new container to the deployment itself.
+  # It should be set using the --set-json option
+  sidecars: []
+
 # Configuration for edge nodes
 edgeNode:
   # Enable edge nodes
@@ -705,5 +716,10 @@ edgeNode:
     browserName: MicrosoftEdge
     sessionBrowserName: 'msedge'
 
+  # It is used to add a sidecars proxy in the same pod of the browser node.
+  # It means it will add a new container to the deployment itself.
+  # It should be set using the --set-json option
+  sidecars: []
+
 # Custom labels for k8s resources
 customLabels: {}